operator
14 lines
1.1 KiB
Plaintext
14 lines
1.1 KiB
Plaintext
# 156-approvals-test-speedup: Approvals test speedup
|
|
|
|
Goal: trim waits in approvals test files
|
|
|
|
Steps:
|
|
1. Read 147 result notes in done/147-slowest-resweep.md.* for the approvals x3 + box_approvals quality_validate targets (~1.2-1.5s each). 2. On a feature branch: reduce sleeps/timeouts keeping all assertions identical (never weaken tests); run the files until green. Done criteria: result notes list before/after seconds + pass counts, or exact blocking failure.
|
|
|
|
Done criteria: result notes appended below; file moved to done/.
|
|
|
|
Result notes (append below before moving to done/):
|
|
|
|
Completed 2026-10-08T22:27:42Z via box tasks done:
|
|
Test-only, 141 in-proc pattern extended. test_box_approvals_https: 12 passed 2.01s->0.07s (25 spawns->inproc incl 18x quality-validate, byte-identical outputs verified). test_approvals: 23 passed 9.31s->6.85s (11 super-cli/box-ctl spawns->inproc; assertions identical). Remaining ~0.9s/scan is genuine production scan cost (6 nodes x audit log); deeper fix needs prod change (single-pass/tail-limited scan, log rotation), out of scope. Touched tests/test_approvals.py + tests/test_box_approvals_https.py only, uncommitted on shared tree.
|