cmd_sidechat_create: exact header check for panel state\n\ninnerText.includes was always true (switcher button text).\nNow checks for exact Side chats header text node, loops up to 5x.

2026-10-04 03:38:22 +00:00
parent 8ff4dd0e30
commit f8b6475396
1 changed files with 22 additions and 11 deletions
@@ -270,20 +270,31 @@ def cmd_sidechat_create(ws):
    - + button: [data-testid="hatch-chat-compose"] (SVG icon, no text)
    """
    import time as _time
-    # Check if + button already present (panel open). If not, open via switcher.
-    # Fixed 2026-10-04: don't blindly click switcher, check state first.
-    has_plus = ev(ws, """(() => {
-      return !!document.querySelector('[data-testid="hatch-chat-compose"]');
+    # Check if panel is open via exact 'Side chats' header text node.
+    # (Not innerText.includes - the switcher button text contains "Open chat and
+    # side chats" which is always true. Must check for the header element.)
+    # Then open via switcher if needed (loop up to 5 attempts).
+    # Fixed 2026-10-04 per chat panel investigation.
+    def _panel_open():
+        return ev(ws, """(() => {
+          const walker = document.createTreeWalker(document.body, NodeFilter.SHOW_TEXT);
+          let n;
+          while (n = walker.nextNode()) {
+            if (n.textContent.trim() === 'Side chats') return true;
+          }
+          return false;
        })()""")
-    if not has_plus:
-        # Panel closed, open via switcher trigger
-        sw_result = ev(ws, """(() => {
+    
+    for _attempt in range(5):
+        if _panel_open():
+            break
+        ev(ws, """(() => {
          const sw = document.querySelector('[data-testid="hatch-chat-switcher-trigger"]');
          if (sw) sw.click();
-          return sw ? 'SWITCHER_CLICKED' : 'NO_SWITCHER';
        })()""")
-        print(f"Switcher: {sw_result}", file=sys.stderr)
-        _time.sleep(2)  # Wait for React render
+        _time.sleep(3)
+    else:
+        print("Warning: panel may not be open after 5 attempts", file=sys.stderr)
    # Find + button via data-testid (verified selector, SVG icon no text)
    result = ev(ws, """(() => {
      const btn = document.querySelector('[data-testid="hatch-chat-compose"]');